703 Ovale thread

Face-rippin fun.

Moderator: Forum Administrators

greenjeans
Honored
Posts: 99
Joined: Tue Jan 31, 2017 9:06 pm

Re: 703 Ovale thread

Post by greenjeans » Mon Jun 05, 2017 1:41 pm

Well, I refactored the older style script with those optional operators (See the other thread, I think you swapped more/atLeast in your description), and didn't notice an appreciable increase in fps...might not be a significant optimization for how much time it would take in your much larger script.

What other complexities could be removed without needing to maintain special flavors of the script? Incarn logic seems like it's a lot...DoS support really worth it?

ShmooDude
Exalted
Posts: 1054
Joined: Tue Feb 08, 2011 5:51 pm

Re: 703 Ovale thread

Post by ShmooDude » Mon Jun 05, 2017 4:02 pm

Yea, removing DoS would be pretty significant since its at the end of the action list. You could remove a lot of lines.

Honestly, the biggest thing would be to implement true pool_resource,for_next=1 functionality from within Ovale, but I'm not sure I have a handle on how to do that. The way its currently being done is that every time you run into this in the simcraft script, Ovale creates an if/unless block which basically means it runs those tests twice. Although in theory, the caching saves a lot of computational time on that. What it should do is if all the conditions EXCEPT energy based conditions are true, to simply stop evaluating there.

I did put in something where you can call Spell(spell_name pool_resource=1) and it will ignore the resource requirement in terms of determining which ability to suggest, but this doesn't always work depending on what the conditions are. Any energy based conditions not inherently called from Spell() won't work. I think it was causing some other oddities too but since there's a lot of energy pooling all over, this won't help that much which is why I haven't used it in a while.

trollhammer
Posts: 2
Joined: Mon Sep 05, 2016 1:30 pm

Re: 703 Ovale thread

Post by trollhammer » Wed Jun 07, 2017 5:49 am

I had this problem, even with the default SIMC script I just reduce the Minimum time for Ovale to choose the next action from 0.05 to 0.3 Ish.. Anymore than 0.3 the actions tend to lag.

Went from 40FPS loss to like 5..

greenjeans
Honored
Posts: 99
Joined: Tue Jan 31, 2017 9:06 pm

Re: 703 Ovale thread

Post by greenjeans » Wed Jun 07, 2017 10:45 am

trollhammer wrote:I had this problem, even with the default SIMC script I just reduce the Minimum time for Ovale to choose the next action from 0.05 to 0.3 Ish.. Anymore than 0.3 the actions tend to lag.

Went from 40FPS loss to like 5..
Did you just edit the Frame.lua? Couldn't find a specific setting for that, but this is a great idea.

trollhammer
Posts: 2
Joined: Mon Sep 05, 2016 1:30 pm

Re: 703 Ovale thread

Post by trollhammer » Wed Jun 07, 2017 2:56 pm

Yeah.

I just changed the below.

Code: Select all

Mininum time in seconds for refreshing the best action.
	local MIN_REFRESH_TIME = 0.X

ShmooDude
Exalted
Posts: 1054
Joined: Tue Feb 08, 2011 5:51 pm

Re: 703 Ovale thread

Post by ShmooDude » Wed Jun 07, 2017 5:22 pm

Could have sworn that used to be a setting (in Ovale), will have to have someone add it back.

kerplunk101
Posts: 23
Joined: Sun Apr 14, 2013 3:48 am

Re: 703 Ovale thread

Post by kerplunk101 » Tue Jun 13, 2017 5:10 am

Shmoo man! Ovale since MOP with RORO!

Will this piece of art be updated today???

ShmooDude
Exalted
Posts: 1054
Joined: Tue Feb 08, 2011 5:51 pm

Re: 703 Ovale thread

Post by ShmooDude » Tue Jun 13, 2017 12:30 pm

Delete

Code: Select all

	[API_GetSpellInfo(171745)] = "druid_claws_of_shirvallah",
line from stance.lua

Should work fine, at least for feral.

Soulshift
Posts: 1
Joined: Tue Jun 13, 2017 4:51 pm

Re: 703 Ovale thread

Post by Soulshift » Tue Jun 13, 2017 4:53 pm

Any update when Ovale will get fixed for 7.2.5, all my addons are updated including the most recent ovale but its constantly hidden. I an access the code and other configurations.

Dewgy
Posts: 26
Joined: Sat Jun 15, 2013 12:07 am

Re: 703 Ovale thread

Post by Dewgy » Tue Jun 13, 2017 5:49 pm

The temporary way to fix it is deleting the line in ovale's stance.lua like shmoo said above. Although you do get a error that says "Unknown spell with ID 192083 used in Spell(19203)" after from Ovalecompiler. That spell Id is Mark of ursol. Coming from the bear part of the script because Mark of ursol no longer exists with 7.2.5. To fix that error constantly spamming your chat for now you can just delete the bear part of the ovale script.

Warelder
Posts: 32
Joined: Sat Feb 18, 2017 2:48 am

Re: 703 Ovale thread

Post by Warelder » Tue Jun 13, 2017 9:44 pm

I can't find this script within the code. Edit** is this on the script on page 1?

**Fixed ty for the assist
Last edited by Warelder on Wed Jun 14, 2017 1:35 am, edited 2 times in total.

ShmooDude
Exalted
Posts: 1054
Joined: Tue Feb 08, 2011 5:51 pm

Re: 703 Ovale thread

Post by ShmooDude » Tue Jun 13, 2017 9:51 pm

Try it now.

hurricanechris
Posts: 5
Joined: Wed Mar 29, 2017 6:24 pm

Re: 703 Ovale thread

Post by hurricanechris » Wed Jun 14, 2017 12:46 pm

Hey Shmoo nice script you cant find this quality for other classes or specc.

I have 2 ovale panels showing me the script at the moment. Did i do something wrong when I deleted the lua line?

Darkmod
Posts: 8
Joined: Wed Jun 14, 2017 2:29 pm

Re: 703 Ovale thread

Post by Darkmod » Wed Jun 14, 2017 2:32 pm

Awesome work!

I just realized you updated the script. You should edit the date 5/29/17 to 6/?/17

Cheers.

ShmooDude
Exalted
Posts: 1054
Joined: Tue Feb 08, 2011 5:51 pm

Re: 703 Ovale thread

Post by ShmooDude » Wed Jun 14, 2017 5:40 pm

Yea, still making a few tweaks which is why I didn't post anything yet. There'll probably be more over the next few days. That said, feel free to update now, should be stable I think. Just let me know if you run into any bugs.

adianar
Honored
Posts: 124
Joined: Thu Apr 28, 2011 12:28 pm

Re: 703 Ovale thread

Post by adianar » Wed Jun 14, 2017 6:58 pm

Thank you Shmoo!

Adi

Shmoo,
I'm pathetic at coding and what any of it means. Any help would be appreciated. Loaded the latest on Page 1 main post. Getting this error in game:

Message: Interface\AddOns\Ovale\AST.lua:2792: attempt to index field 'STANCE_NAME' (a nil value)
Time: 06/14/17 18:08:58
Count: 1
Stack: Interface\AddOns\Ovale\AST.lua:2792: attempt to index field 'STANCE_NAME' (a nil value)Interface\SharedXML\SharedBasicControls.lua:204: in function <Interface\SharedXML\SharedBasicControls.lua:203>
(tail call): ?
Interface\AddOns\Ovale\AST.lua:2792: in function `VerifyParameterStances'
Interface\AddOns\Ovale\AST.lua:2554: in function `ParseScript'
Interface\AddOns\Ovale\Compile.lua:676: in function `CompileScript'
Interface\AddOns\Ovale\Compile.lua:630: in function `?'
...ibraries\CallbackHandler-1.0\CallbackHandler-1.0.lua:145: in function <...ibraries\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
[C]: ?
[string "safecall Dispatcher[1]"]:13: in function `?'
...ibraries\CallbackHandler-1.0\CallbackHandler-1.0.lua:90: in function `SendMessage'
Interface\AddOns\Ovale\Scripts.lua:137: in function `SetScript'
Interface\AddOns\Ovale\DataBroker.lua:95: in function `func'
Interface\FrameXML\UIDropDownMenu.lua:791: in function `UIDropDownMenuButton_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals: <none>

Ogretoes
Posts: 5
Joined: Fri Sep 30, 2016 12:02 am

Re: 703 Ovale thread

Post by Ogretoes » Wed Jun 14, 2017 8:05 pm

Hello All....I have so much trouble with these updates. So I updated Ovale. I loaded the new Schmoo script into custom scripts. Now my Ovale boxes won't show up on the interface. I read through the last few pages and it looks like I'm supposed to delete something from the Ovale stance.lua. I looked under Wow interface, found the ovale add, but can't open the stance lua. Any help?

Stupid and Frustrated in Indy....../sigh

User avatar
Arthaei
Honored
Posts: 64
Joined: Tue Mar 15, 2011 12:37 pm
Location: Wales, UK

Re: 703 Ovale thread

Post by Arthaei » Thu Jun 15, 2017 3:58 am

Hi Ogretoes, you can open the file by rightclicking it and selecting 'open with' and then open this in Notepad. The error is removed by adding two dashes like this: -- before that line. It's a stopgap for now before it gets updated.

@shmoodude - Thanks for all your hard work! is the updated code synergizing with concordance and bloodletters by the way? it seems good, I just don't know if it's reactive like that?
"Many druids died to bring us this information"

Ryvella
Posts: 7
Joined: Mon Aug 01, 2016 12:04 pm

Re: 703 Ovale thread

Post by Ryvella » Thu Jun 15, 2017 7:48 am

Hi SmooDude

it looks like there is no prediction of shadowmeld anymore

ShmooDude
Exalted
Posts: 1054
Joined: Tue Feb 08, 2011 5:51 pm

Re: 703 Ovale thread

Post by ShmooDude » Thu Jun 15, 2017 9:47 am

Ryvella wrote:Hi SmooDude

it looks like there is no prediction of shadowmeld anymore
Should be fixed now.

Ogretoes
Posts: 5
Joined: Fri Sep 30, 2016 12:02 am

Re: 703 Ovale thread

Post by Ogretoes » Thu Jun 15, 2017 10:57 am

Thanks for the update on Stance.lua.

Thank you too Schmoo for the many hours of enjoyment you've provided me while playing my Druid. Curious if you have your own website where we can make a donation?

Thanks again, Toes

Ogretoes
Posts: 5
Joined: Fri Sep 30, 2016 12:02 am

Re: 703 Ovale thread

Post by Ogretoes » Thu Jun 15, 2017 11:32 am

Thanks Arthaei on the Stance.lua. Worked perfectly!

And thank you Schmoo for all the hours of enjoyment you've provided me while playing my Druid. I'd like to donate for all the work you do.

Toes

adianar
Honored
Posts: 124
Joined: Thu Apr 28, 2011 12:28 pm

Re: 703 Ovale thread

Post by adianar » Thu Jun 15, 2017 1:07 pm

@Arthaei Thank you for that description as well. I'm not getting the boxes, but at least I'm not getting errors constantly. Much appreciated!!

Adi

ShmooDude
Exalted
Posts: 1054
Joined: Tue Feb 08, 2011 5:51 pm

Re: 703 Ovale thread

Post by ShmooDude » Thu Jun 15, 2017 1:33 pm

Not sure why that would be. Removing the line from Stance.lua is really the only thing keeping it from working. Might try resetting the settings for the addon and then reapply the custom script?

User avatar
Arthaei
Honored
Posts: 64
Joined: Tue Mar 15, 2011 12:37 pm
Location: Wales, UK

Re: 703 Ovale thread

Post by Arthaei » Thu Jun 15, 2017 6:06 pm

Glad to help, make sure you have the latest version of Ovale (I set mine to alpha release in curse client), and copy and paste in Shmoo's code from page 1 of this thread, it gets updated there.
"Many druids died to bring us this information"

Post Reply