I started to work on a ticket, but it became clear to me that I don't understand how Ovale is calculating combo points on a target right now. It looks like it is calling GetComboPoints() every time a "Damage" event happens (by setting a refreshNeeded flag on the player). I have not found where it uses the "combo=" parameter on SpellInfo. I am assuming that it will use that when it determines that a spell has been cast, but there does seem to be some lag.Jeshu wrote:@Leafkiller: Could you open a ticket for the feral ability that grants the extra combo point? I tried finding the post about how it worked, but didn't see it during my search.
Druids have a passive ability called Primal Fury (http://www.wowhead.com/spell=16961) which returns 15 rage on Mangle and auto-attacks while in Bear form and two combo points while in cat form from single target combo point abilities (Mangle, Rake, Shred, Ravage, Shred! and Ravage!).
So I have some questions for you. First, does the predicitive code use the "combo=" parameter to update the combo points for script evaluation? If it does do that, when is it done? Is it relying on the API call, GetComboPoints() to update the combo points after every event that it cares about?
The "SPELL_DAMAGE" event is sufficient to determine when a combo point has been added. It is also sufficient to determine when two need to be added. Here is some lua code that aggixx wrote into a Weak Aura to see how many combo points to add: Here are two Mangles from a combat log, the first is a normal hit, and the second is a crit:
Note that the third to last parameter is the crit indicator.11/27 23:58:26.888 SPELL_DAMAGE,0x0200000005C273A4,"Leafkiller",0x511,0x0,0xF53079AA0000417F,"Raider's Training Dummy",0x10a28,0x0,33876,"Mangle",0x1,19320,-1,1,0,0,0,nil,nil,nil
11/27 23:58:28.856 SPELL_DAMAGE,0x0200000005C273A4,"Leafkiller",0x511,0x0,0xF53079AA0000417F,"Raider's Training Dummy",0x10a28,0x0,33876,"Mangle",0x1,38979,-1,1,0,0,0,1,nil,nil
Since Ovale is spell agnostic, my idea is to add a new parameter to SpellInfo to tell it to add two combo points for crits on certain spells. For example:
Code: Select all
Define(MANGLECAT 33876) #cat bleed+debuff SpellInfo(MANGLECAT inccounter=ripshreds energy=35 combo=1 critcombo=2)
I am happy to post a ticket requesting an enhancement, but I want to make sure I understand what Ovale is currently doing, so I know what to post. Can you provide some insight into the current workings?