Simulationcraft - Feral rotation discussion and script

[Leafkiller]

Can you elaborate on the pre-conditioning? Are you suggesting we have several scripts depending on the talent combination, or a way to modify the script the user sees based on the talents using some conditionals in the script?

[Leafkiller]

BTW, I just looked at the action list you posted. If I simply removed two of the tier 4 talents that are not sued as often, Force of Nature and Incarnation, it would save at least 11 lines in the script. There are some changes I would make to that based on the work that has gone into the current BiS script, particularly ones that deal with some of the difficulties we see in game executing the script.

[Caltiom]

Can you elaborate on the pre-conditioning? Are you suggesting we have several scripts depending on the talent combination, or a way to modify the script the user sees based on the talents using some conditionals in the script?

Well there are two general ways to adapt a action list to the user in SimC:

1) When importing a Character ( let's say from the armory ), you parse his Class, Spec, Talents, Glyphs, Race, Level, and build a custom action list tailored to that setup. Easily done with some if / else statements in eg. druid_t::init_actions().

The advantage is that you have a small and efficient action list for exactly the things you need.

2) Don't assume any specializations when creating the action list ( besides Class and Specialization maybe ) and add run-time conditionals to the action list:
For example something like this:
actions.single+=/unleash_elements,if=talent.unleashed_fury.enabled

or
actions += /blood_fury,if=race=orc

This makes it much easier if you want to change eg. talents manually in the input text after import, but bloats the action list massively.

We haven't really decided on a special way to go, depends on the class developer ( I'd say 7-8 out of ten class_t::init_actions() functions are horribly done, outdated or both anyway ).

Just have a look at http://code.google.com/p/simulationcraf ... t.cpp#4815 that's one of the better maintained ( at least for shadow ) ones, with a lot of preconditioning.

[raffy]

actions.single+=/unleash_elements,if=talent.unleashed_fury.enabled

Maybe simc could add support for a direct talent query, this way the entire statement can be dropped from the action list (although it's only a very minor optimization):

Code: Select all

/unleash_elements,talent=unleashed_fury

[aggixx]

@Raffy: No idea what you're trying to say.

( I'd say 7-8 out of ten class_t::init_actions() functions are horribly done, outdated or both anyway ).

Implying there is 10 classes

I'll look at that code a little bit and maybe see what I could do along those lines.

[raffy]

@Raffy: No idea what you're trying to say.

Maybe my simc expression parser is just shitty but, when I encounter an if-expression, I parse it into a condition object that I can evaluate to a boolean, and then add it to my action list as the pair: <Spell, IfCond> Then during simulation evaluation, for each <Spell,IfCond> if (IfCond) do Spell.

Whereas, if I knew, at the time of parsing, that one of the conditions involves a constant (a talent), I could straight up drop the condition from my action list. Now that I write this, I can probably just add this feature to my own code w/o a script modification.

I was just suggesting, that it might be more clearly stated, that if the entire action depends on some talent, you could pull the talent out of the if-expression so it could be tested directly. Or, maybe as a more flexible option, something like:

Code: Select all

actions+=/spell,require=talent.unleashed_fury.enabled,if=blah.blah

Where require-expression is evaluated once, for inclusion in the action list, and if-expression is evaluated for each action list evaluation.

[Leafkiller]

Thanks for listing the options for customizing the script at import time. It is very helpful.

The shadow priest code has broken down script generation to a very detailed level, literally adding specific actions depending on different conditionals, which is more fine-grained than what I am thinking of - simply breaking what we have now into four scripts.

In each of the key dps tiers for ferals, tier 4 and tier 6, two of the talents are pretty similar for what we model in the rotation, and one talent is different. For tier 4, Soul of the Forest (SotF) changes the rotation significantly while Force of Nature (FoN) and Incarnation (Inc) are pretty similar (Inc changes the filler we use to Ravage! from Shred while it is active, but the actions are identical other than the spell being cast). In tier 6, Dream of Cenarius (DoC) has a very complex rotation, while Nature's Vigil (NV) and Heart of the Wild (HotW) have very similar rotations that are simpler than the DoC rotation.

We end up with a 2x2 matrix for rotations to support (which is better than trying to deal with a 3x3 matrix or 9 rotations):

Code: Select all

SotF+HotW/NV        Inc/FoN+HotW/NV
SotF+DoC               Inc/FoN+DoC

This breakdown will make the rotations a user sees much simpler and will allow us to focus on optimizing each of the four rotations separately without worrying about side effects. It is a very common design pattern for managing complexity in state machines.

[Leafkiller]

@Raffy - I don't think we are going to get changes to the simc rotation at that level since what they have works.

On a separate but related note (and related to my last post), the complexity we are dealing with for the feral rotation is more than is typical for a spec. It is closer to the complexity for modeling the different specs in the pure classes. Due to the way Blizzard built our talent trees, we literally have four rotations with significant differences. Even compared to the other Druid classes, the impact of the talents is much more significant for ferals. I think this is central to the push back we have gotten from the simc community on the complexity of our rotation, since they are used to separate action lists for the different specs in classes, and don't really think of the feral on the same level as, for example, a rogue, but rather see us more on the level of, for example, a subtlety rogue.

Breaking the current script into four scripts recognizes the complexity we are dealing with.

[raffy]

Breaking the current script into four scripts recognizes the complexity we are dealing with.

I think this is a good idea but I'm worried (for my own ability to use the script) how this is gonna be implemented. Is there gonna be 4 separate scripts? Or is the action list code going to get hardcoded into simc's source (re: druid_t::init_actions(), etc..). I'd vote for as much logic as possible staying in the script.

[Leafkiller]

I was thinking of four separate scripts per the matrix above. Based on the user's spec we would simply import the appropriate script/action list. This will be trivial for you to deal with (and me in Ovale).

[aggixx]

I don't think seperating into that many scripts is the right choice, it would make it a huge chore to maintain. I already wrote the code for generating the action list line-by-line based on talent requirements etc, we just need to make things a bit less daunting in general.

[Leafkiller]

I think there is an advantage to going to 4 chunks since we are starting to deal with side effects now and that is a natural break down. I will probably give that a try and see what the rotations look like and if I can improve them more easily that way.

Can you post your code somewhere so I can see what you are doing?

[aggixx]

I did notice that there is a significant DPS discrepancy between the action list we've been using and a generated one so I definitely messed something up somewhere, I'll see if I can take some time to find the problem tomorrow and then I'll upload a patch file somewhere.

[aggixx]

Here's a newer version of the script that uses frag belt. I also made some logical DPS neutral changes in line priority.

Spoiler: show

Code: Select all

#!./simc 

druid="Druid_Feral_T14H"
origin="unknown"
level=90
race=troll
spec=feral
role=attack
position=back
professions=engineering=600/inscription=600
talents=010102
glyphs=savagery

$(rip_remains)=(dot.rip.remains+(8-(dot.rip.ticks_added*2)))

actions.precombat=flask,type=spring_blossoms
actions.precombat+=/food,type=sea_mist_rice_noodles
actions.precombat+=/mark_of_the_wild,if=!aura.str_agi_int.up
actions.precombat+=/healing_touch,if=!buff.dream_of_cenarius_damage.up&talent.dream_of_cenarius.enabled
actions.precombat+=/cat_form
actions.precombat+=/savage_roar
actions.precombat+=/snapshot_stats
actions.precombat+=/virmens_bite_potion
actions.precombat+=/treants,if=talent.force_of_nature.enabled

actions=auto_attack
actions+=/skull_bash_cat
actions+=/berserking
actions+=/use_item,name=stalkers_cord_of_eternal_autumn,use_off_gcd=1

actions+=/use_item,name=eternal_blossom_grips,if=buff.heart_of_the_wild.up
#actions+=/heart_of_the_wild,if=enabled
actions+=/virmens_bite_potion,if=buff.heart_of_the_wild.up|target.time_to_die<=40
actions+=/wrath,if=cast_time<buff.heart_of_the_wild.remains
actions+=/cat_form,if=buff.cat_form.down

actions+=/healing_touch,if=talent.dream_of_cenarius.enabled&buff.predatory_swiftness.up&buff.predatory_swiftness.remains<=1.5&buff.dream_of_cenarius_damage.down
actions+=/savage_roar,if=buff.savage_roar.down
actions+=/healing_touch,if=talent.dream_of_cenarius.enabled&buff.predatory_swiftness.up&combo_points>=4&buff.dream_of_cenarius_damage.stack<2
actions+=/healing_touch,if=talent.dream_of_cenarius.enabled&prev.natures_swiftness

actions+=/use_item,name=eternal_blossom_grips,sync=tigers_fury
actions+=/tigers_fury,if=energy<=35&!buff.omen_of_clarity.react
actions+=/berserk,if=buff.tigers_fury.up|(target.time_to_die<15&cooldown.tigers_fury.remains>6)
actions+=/natures_vigil,if=buff.berserk.up&talent.natures_vigil.enabled
actions+=/incarnation,if=buff.berserk.up&talent.incarnation.enabled

actions+=/ferocious_bite,if=combo_points>=1&dot.rip.ticking&dot.rip.remains<=2&target.health.pct<=25
actions+=/faerie_fire,if=debuff.weakened_armor.stack<3

actions+=/thrash_cat,if=target.time_to_die>=6&buff.omen_of_clarity.react&dot.thrash_cat.remains<3&buff.dream_of_cenarius_damage.down

actions+=/ferocious_bite,if=(target.time_to_die<=4&combo_points>=5)|(target.time_to_die<=1&combo_points>=3)

actions+=/natures_swiftness,if=enabled&talent.dream_of_cenarius.enabled&buff.dream_of_cenarius_damage.down&buff.predatory_swiftness.down&combo_points>=5&target.health.pct<=25
actions+=/virmens_bite_potion,if=(talent.dream_of_cenarius.enabled&combo_points>=5&target.health.pct<=25&buff.dream_of_cenarius_damage.up)|(!talent.dream_of_cenarius.enabled&buff.berserk.up&target.health.pct<=25)|target.time_to_die<=40
actions+=/rip,if=combo_points>=5&buff.virmens_bite_potion.up&(buff.dream_of_cenarius_damage.up|!talent.dream_of_cenarius.enabled)&dot.rip.multiplier<tick_multiplier&target.health.pct<=25&target.time_to_die>30
actions+=/rip,if=combo_points>=5&tick_multiplier%dot.rip.multiplier>1.14&target.health.pct<=25&target.time_to_die>30

actions+=/savage_roar,if=buff.savage_roar.remains<3&combo_points>0&buff.dream_of_cenarius_damage.down&target.health.pct<25

actions+=/pool_resource,wait=0.1,if=combo_points>=5&dot.rip.ticking&target.health.pct<=25&((energy<50&buff.berserk.down)|(energy<25&buff.berserk.remains>1))&talent.dream_of_cenarius.enabled
actions+=/ferocious_bite,if=combo_points>=5&dot.rip.ticking&target.health.pct<=25

actions+=/rip,if=combo_points>=5&target.time_to_die>=6&dot.rip.remains<2.0&buff.dream_of_cenarius_damage.up
actions+=/rip,if=combo_points>=5&target.time_to_die>=6&dot.rip.remains<6.0&buff.dream_of_cenarius_damage.up&dot.rip.multiplier<=tick_multiplier&target.health.pct>25

actions+=/natures_swiftness,if=enabled&talent.dream_of_cenarius.enabled&buff.dream_of_cenarius_damage.down&buff.predatory_swiftness.down&combo_points>=5&dot.rip.remains<3&(buff.berserk.up|dot.rip.remains+1.9<=cooldown.tigers_fury.remains)&target.health.pct>25
actions+=/rip,if=combo_points>=5&target.time_to_die>=6&dot.rip.remains<2.0&(buff.berserk.up|dot.rip.remains+1.9<=cooldown.tigers_fury.remains)

actions+=/savage_roar,if=buff.savage_roar.remains<3&combo_points>0&buff.savage_roar.remains+2>dot.rip.remains

actions+=/thrash_cat,if=target.time_to_die>=6&buff.omen_of_clarity.react&dot.thrash_cat.remains<3

actions+=/ravage,extend_rip=1,if=dot.rip.ticking&dot.rip.remains<=4
actions+=/shred,extend_rip=1,if=dot.rip.ticking&dot.rip.remains<=4&buff.king_of_the_jungle.down

actions+=/savage_roar,if=buff.savage_roar.remains<=6&combo_points>=5&buff.savage_roar.remains+2<=$(rip_remains)

actions+=/pool_resource,wait=0.1,if=talent.dream_of_cenarius.enabled&combo_points>=5&((energy<50&buff.berserk.down)|(energy<25&buff.berserk.remains>1))&buff.savage_roar.remains-6>=$(rip_remains)&$(rip_remains)>=4.5
actions+=/pool_resource,wait=0.1,if=talent.dream_of_cenarius.enabled&combo_points>=5&((energy<50&buff.berserk.down)|(energy<25&buff.berserk.remains>1))&buff.savage_roar.remains+6>=$(rip_remains)&$(rip_remains)>=6.5
actions+=/ferocious_bite,if=talent.dream_of_cenarius.enabled&combo_points>=5&buff.savage_roar.remains-6>=$(rip_remains)&$(rip_remains)>=4
actions+=/ferocious_bite,if=talent.dream_of_cenarius.enabled&combo_points>=5&buff.savage_roar.remains+6>=$(rip_remains)&$(rip_remains)>=6
actions+=/pool_resource,wait=0.1,if=talent.dream_of_cenarius.enabled&combo_points>=5&((energy<50&buff.berserk.down)|(energy<25&buff.berserk.remains>1))&$(rip_remains)>=10.5
actions+=/ferocious_bite,if=talent.dream_of_cenarius.enabled&combo_points>=5&$(rip_remains)>=10

actions+=/ferocious_bite,if=combo_points>=5&($(rip_remains)>10|($(rip_remains)>6&buff.berserk.up))&dot.rip.ticking

actions+=/rake,if=target.time_to_die-dot.rake.remains>3&dot.rake.remains<6.0&buff.dream_of_cenarius_damage.up&dot.rake.multiplier<=tick_multiplier
actions+=/rake,if=target.time_to_die-dot.rake.remains>3&tick_multiplier%dot.rake.multiplier>1.12
actions+=/rake,if=target.time_to_die-dot.rake.remains>3&dot.rake.remains<3.0&(buff.berserk.up|(cooldown.tigers_fury.remains+0.8)>=dot.rake.remains|energy>60)

actions+=/ravage,if=buff.omen_of_clarity.react
actions+=/shred,if=buff.omen_of_clarity.react&buff.king_of_the_jungle.down
actions+=/ravage,if=((combo_points<5&dot.rip.remains<3.0)|(combo_points=0&buff.savage_roar.remains<2))
actions+=/shred,if=((combo_points<5&dot.rip.remains<3.0)|(combo_points=0&buff.savage_roar.remains<2))&buff.king_of_the_jungle.down
actions+=/thrash_cat,if=target.time_to_die>=15&dot.thrash_cat.remains<3&buff.berserk.up&talent.soul_of_the_forest.enabled&talent.dream_of_cenarius.enabled
actions+=/ravage,if=talent.dream_of_cenarius.enabled&buff.predatory_swiftness.remains>1&!(energy+(energy.regen*(buff.predatory_swiftness.remains-1))<(4-combo_points)*20)
actions+=/ravage,if=!talent.dream_of_cenarius.enabled&talent.soul_of_the_forest.enabled&combo_points<5&(energy+(energy.regen*(4-combo_points))>(5-combo_points)*20)
actions+=/ravage,if=target.time_to_die<=8.5
actions+=/shred,if=talent.dream_of_cenarius.enabled&buff.predatory_swiftness.remains>1&!(energy+(energy.regen*(buff.predatory_swiftness.remains-1))<(4-combo_points)*20)&buff.king_of_the_jungle.down
actions+=/shred,if=!talent.dream_of_cenarius.enabled&talent.soul_of_the_forest.enabled&combo_points<5&(energy+(energy.regen*(4-combo_points))>(5-combo_points)*20)&buff.king_of_the_jungle.down
actions+=/shred,if=target.time_to_die<=8.5&buff.king_of_the_jungle.down
actions+=/thrash_cat,if=target.time_to_die>=6&combo_points>=5&dot.thrash_cat.remains<6&(buff.tigers_fury.up|buff.berserk.up|buff.natures_vigil.up)
actions+=/thrash_cat,if=target.time_to_die>=6&combo_points>=5&dot.thrash_cat.remains<6&cooldown.tigers_fury.remains<=3.0
actions+=/thrash_cat,if=target.time_to_die>=6&combo_points>=5&dot.thrash_cat.remains<6&energy.time_to_max<=1.0
actions+=/ravage,if=(buff.tigers_fury.up|buff.berserk.up|buff.natures_vigil.up)
actions+=/ravage,if=cooldown.tigers_fury.remains<=3.0
actions+=/ravage,if=energy.time_to_max<=1.0
actions+=/shred,if=(buff.tigers_fury.up|buff.berserk.up|buff.natures_vigil.up)&buff.king_of_the_jungle.down
actions+=/shred,if=cooldown.tigers_fury.remains<=3.0&buff.king_of_the_jungle.down
actions+=/shred,if=energy.time_to_max<=1.0&buff.king_of_the_jungle.down
actions+=/treants,if=talent.force_of_nature.enabled
actions+=/natures_swiftness,if=enabled&buff.natures_vigil.up&!buff.berserk.up&!buff.predatory_swiftness.up
actions+=/healing_touch,if=buff.natures_vigil.up&(buff.predatory_swiftness.up|buff.natures_swiftness.up)&!buff.berserk.up

head=eternal_blossom_headpiece,id=86925,gems=agile_primal_80agi_160hit_180agi,reforge=exp_crit
neck=choker_of_the_unleashed_storm,id=86953
shoulders=eternal_blossom_spaulders,id=86927,gems=80agi_160hit_60agi,enchant=520agi_100crit,reforge=haste_mastery
back=legbreaker_greatcloak,id=86963,enchant=180hit,reforge=crit_exp
chest=eternal_blossom_raiment,id=86923,gems=80agi_160mastery_80agi_160mastery_120mastery,enchant=80all
wrists=bracers_of_unseen_strikes,id=86954,enchant=180agi,reforge=haste_mastery
hands=eternal_blossom_grips,id=86924,enchant=170mastery,addon=synapse_springs_mark_ii,reforge=hit_mastery
waist=stalkers_cord_of_eternal_autumn,id=87180,gems=160agi_160agi,reforge=crit_mastery,addon=frag_belt
legs=legguards_of_failing_purification,id=90504,gems=160agi_80agi_160hit_120agi,enchant=285agi_165crit,reforge=hit_exp
feet=boots_of_the_still_breath,id=86943,gems=160agi,enchant=140mastery,reforge=haste_mastery
finger1=regails_band_of_the_endless,id=90503,reforge=haste_mastery
finger2=painful_thorned_ring,id=86974,reforge=exp_crit
trinket1=terror_in_the_mists,id=87167
trinket2=bottle_of_infinite_stars,id=87057
main_hand=gaorei_staff_of_the_legendary_protector,id=87156,gems=500agi,enchant=dancing_steel,reforge=exp_hit,addon=7932sp

# Gear Summary
# gear_strength=80
# gear_agility=17296
# gear_stamina=20502
# gear_intellect=80
# gear_spirit=80
# gear_expertise_rating=2537
# gear_hit_rating=2545
# gear_crit_rating=5124
# gear_haste_rating=1351
# gear_mastery_rating=8406
# gear_armor=18644
# meta_gem=agile_primal
# tier14_2pc_melee=1
# tier14_4pc_melee=1
# hands=eternal_blossom_grips,heroic=1,addon=synapse_springs_mark_ii
# main_hand=gaorei_staff_of_the_legendary_protector,heroic=1,weapon=staff_3.30speed_13314min_19972max,enchant=dancing_steel

[aggixx]

Found the issue with the modifications I made to druid:init_actions(), here's a link to a patch file:
https://dl.dropbox.com/u/1086121/sc_druid.cpp.patch

[raffy]

@aggixx, you're just using that code to generate a script based on talents and stuff correct?

[aggixx]

I'm still using the old script but if you patch your sc_druid.cpp with that then it will generate a talent specific script that does the same DPS, yes.

[Sorcerer]

There seems to be a gear pickup mistake in simcraft.

Feet - Boots of Still Breath should be replaced with Treads of Deadly Secretions

Haste/crit is simming lower for me than mastery/exp

[aggixx]

Sounds good, thanks for the notice. I made that BiS list months ago before we knew where any of the stuff came from and what was and wasn't obtainable, so I probably just missed em or thought they were a heroic trash drop =)

[Sorcerer]

Btw, there are 509 bracers, heroic version of HoF trash drop. Thing is, they are available only through BMAH ... THX blizzard.
They are mastery + hit I think, but yeah, pointless to change.

[raffy]

Few minor requests:

1. Could the AoE rotation be reposted as a full simc script (complete with shebang and gear stuff), instead of just the action list snippet? I have trouble parsing it automatically because I can't figure out (without some kludgy hack) the /use_item slot from the eternal_blossom_grips -> Hands.

2. Also, I asked aggixx about this last night but I think my question was wrong (as I was wondering about DoC), could the AoE script be improved to support HotW and NV?

3. For the primary rotation, could Lifeblood and Frag Belt be added?

[Etapicx]

Btw, there are 509 bracers, heroic version of HoF trash drop. Thing is, they are available only through BMAH ... THX blizzard.
They are mastery + hit I think, but yeah, pointless to change.

Mastery and Exp got em on normal ^^

And guys keep up the good work

[Terias]

Did anyone notice they fixed thrash/swipe + doc?

It no longer consumes both charges of doc when you use it with an aoe ability that hits more than one mob.

I'm assuming this was fixed in 5.1.

[Sorcerer]

Why DPS disproportion on simcraft.org between 5.05 and 5.1? I can't find any difference between them, but the 5.1 is lower.

[Tinderhoof]

Did anyone notice they fixed thrash/swipe + doc?

It no longer consumes both charges of doc when you use it with an aoe ability that hits more than one mob.

I'm assuming this was fixed in 5.1.

They actually fxied this sometime before. Swipe is the same way now and only consumes 1 stack. I noticed the fix around the time of the HoF release (saw during our first Windlord attempts). Just didn't get around to writting it up.