Leafkiller's MoP Feral/Guardian Ovale Script

Face-rippin fun.

Moderator: Forum Administrators

Locked
Jeshu
Revered
Posts: 244
Joined: Tue Dec 14, 2010 5:34 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Jeshu » Sat Oct 19, 2013 2:04 am

Fixed. There was an error in Ovale, but there is also an error in the live script. I've committed fixes to both.

User avatar
aggixx
Exalted
Posts: 2292
Joined: Fri Nov 25, 2011 7:49 pm
Contact:

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by aggixx » Sat Oct 19, 2013 2:42 am

Excellent, thank you.
ImageImage

Andanas
Honored
Posts: 63
Joined: Fri May 28, 2010 5:44 am

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Andanas » Sat Oct 19, 2013 1:15 pm

Not sure if related, or fixed in the upcoming fix, but I get this error in Ovale Spell Priority 5.4.3beta2, as soon as I log in.
Spoiler: show
Date: 2013-10-19 12:02:47
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\Ovale\OvaleSkada.lua line 43:
attempt to index upvalue 'OvaleScore' (a nil value)
Debug:
(tail call): ?
Ovale\OvaleSkada.lua:43:
Ovale\OvaleSkada.lua:39
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9:
[string "safecall Dispatcher[1]"]:5
(tail call): ?
Ace3\AceAddon-3.0\AceAddon-3.0.lua:558: EnableAddon()
Ace3\AceAddon-3.0\AceAddon-3.0.lua:571: EnableAddon()
Ace3\AceAddon-3.0\AceAddon-3.0.lua:651:
Ace3\AceAddon-3.0\AceAddon-3.0.lua:636
[C]: LoadAddOn()
..\FrameXML\UIParent.lua:303: UIParentLoadAddOn()
..\FrameXML\UIParent.lua:326: CombatLog_LoadUI()
..\FrameXML\UIParent.lua:739:
..\FrameXML\UIParent.lua:702
Locals:
None
AddOns:
Swatter, v5.18.5433 (PassionatePhascogale)
Ace3, v
ArkInventory, v30331
ArkInventoryRules, v
ArkInventoryRulesExample, v1.00
AskMrRobot, v1.1.11.0
AucAdvanced, v5.18.5433 (PassionatePhascogale)
AucFilterBasic, v5.18.5433 (PassionatePhascogale)
AucFilterOutlier, v5.18.5433.5347(5.18/embedded)
AucMatchUndercut, v5.18.5433.5364(5.18/embedded)
AucStatHistogram, v5.18.5433 (PassionatePhascogale)
AucStatiLevel, v5.18.5433 (PassionatePhascogale)
AucStatPurchased, v5.18.5433 (PassionatePhascogale)
AucStatSales, v5.18.5433.5376(5.18/embedded)
AucStatSimple, v5.18.5433 (PassionatePhascogale)
AucStatStdDev, v5.18.5433 (PassionatePhascogale)
AucStatWOWEcon, v5.18.5433.5323(5.18/embedded)
AucUtilAHWindowControl, v5.18.5433.5347(5.18/embedded)
AucUtilAppraiser, v5.18.5433.5427(5.18/embedded)
AucUtilAskPrice, v5.18.5433.5347(5.18/embedded)
AucUtilAutoMagic, v5.18.5433.5415(5.18/embedded)
AucUtilCompactUI, v5.18.5433.5427(5.18/embedded)
AucUtilEasyBuyout, v5.18.5433.5427(5.18/embedded)
AucUtilFixAH, v5.18.5433 (PassionatePhascogale)
AucUtilItemSuggest, v5.18.5433.5417(5.18/embedded)
AucUtilPriceLevel, v5.18.5433.5427(5.18/embedded)
AucUtilScanButton, v5.18.5433.5403(5.18/embedded)
AucUtilScanFinish, v5.18.5433.5347(5.18/embedded)
AucUtilScanProgress, v5.18.5433.4979(5.18/embedded)
AucUtilScanStart, v5.18.5433.5347(5.18/embedded)
AucUtilSearchUI, v5.18.5433.5373(5.18/embedded)
AucUtilSimpleAuction, v5.18.5433.5415(5.18/embedded)
AucUtilVendMarkup, v5.18.5433.4828(5.18/embedded)
Babylonian, v5.1.DEV.332(/embedded)
BeanCounter, v5.18.5433 (PassionatePhascogale)
Chinchilla, vv2.6
CollectMe, v2.4.5
Configator, v5.1.DEV.344(/embedded)
DBMCore, v
DBMLDB, v
DBMProfiles, v1.0.4
DebugLib, v5.1.DEV.337(/embedded)
Decursive, v2.7.3
Dominos, v5.4.3
DominosBufftimes, v
DominosCast, v
DominosEncounter, v
DominosRoll, v
DominosXP, v
DroodFocus, v5.2.3
EasyMail, v
Enchantrix, v5.18.5433 (PassionatePhascogale)
EnchantrixBarker, v5.18.5433 (PassionatePhascogale)
GatherMate2, v1.27
HideBossFrames, v2.5.3
kgPanels, v1.17
LibExtraTip, v5.12.DEV.355(/embedded)
LibMapData10, v1.0.0.30-release
NerienOvaleScripts, v5.4.4
OmniCC, v5.4.1
Ovale, v5.4.3beta
PetBattleTeams, v3.2.5
PetJournalEnhanced, v2.9.8
PitBull4, vv4.0.0-beta48
Prat30, v3.5.7
Prat30HighCPUUsageModules, v
Prat30Libraries, v
Quartz, v3.1.4
Reforgerade, v0.1 r52
Routes, vv1.4.2-8-g4b93fad
SilverDragon, vv3.0.10
Skada, v1.4-14
SkadaAvoidanceMitigation, v1.1.4
SkadaCC, v1.0
SkadaDamage, v1.0
SkadaDamageTaken, v1.0
SkadaDeaths, v1.0
SkadaDebuffs, v1.0
SkadaDispels, v1.0
SkadaEnemies, v1.0
SkadaForTanks, v50400.1.0
SkadaHealing, v1.0
SkadaPower, v1.0
SkadaSurvivability, v1.0
SkadaThreat, v1.0
SlideBar, v5.18.5433 (PassionatePhascogale)
Stubby, v5.18.5433 (PassionatePhascogale)
TellMeWhen, v6.2.6
TidyPlates, v6.12.6
TidyPlatesGraphite, v
TidyPlatesGrey, v
TidyPlatesNeon, v
TidyPlatesQuatre, v
TidyPlatesThreatPlates, v6.008
TidyPlatesHub, v
TidyPlatesWidgets, v
TipHelper, v5.12.DEV.351(/embedded)
Tipsy, v$project-version$
TipTac, v13.09.21
TipTacItemRef, v13.09.21
TipTacMSP, v5.3.001
TipTacOptions, v13.09.21
TipTacTalents, v13.09.21
Titan, v5.2.0.50400
TitanBag, v5.2.0.50400
TitanClock, v5.2.0.50400
TitanCurrency, v5.9
TitanGold, v5.2.0.50400
TitanGuild, v5.4.0.0
TitanLocation, v5.2.0.50400
TitanLootType, v5.2.0.50400
TitanPerformance, v5.2.0.50400
TitanRepair, v5.2.0.50400
TitanSocial, v5.4r24
TitanSpec, v3.1
TitanVolume, v5.2.0.50400
TitanXP, v5.2.0.50400
TrickOrTreat, v
VuhDo, v3.53
VuhDoOptions, v3.53
WeakAuras, v1.4.7.10
WIM, v3.6.10
xCT, v3.4.3
BlizRuntimeLib_enUS v5.4.0.50400 <eu>
(ck=eef)
Haven't tried combat yet, just wanted to get this up first.
Last edited by Andanas on Sun Oct 20, 2013 6:46 pm, edited 1 time in total.

Jeshu
Revered
Posts: 244
Joined: Tue Dec 14, 2010 5:34 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Jeshu » Sat Oct 19, 2013 6:29 pm

Was this the only error that popped up? My best guess is that it's using the wrong TOC file that doesn't list OvaleScore.lua. Was this updated through Curse Client?

Andanas
Honored
Posts: 63
Joined: Fri May 28, 2010 5:44 am

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Andanas » Sat Oct 19, 2013 8:54 pm

Yea it's the only error that popped up, and yes, it was updated through the curse client. I didn't notice any effects while in combat though.

Kihrawr
Honored
Posts: 52
Joined: Wed May 25, 2011 3:12 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Kihrawr » Sun Oct 20, 2013 10:49 am

Latest script is buggy when it comes to Rake. It switches to showing Mangle during the GCD of Rake. After the GCD from your Rake ends, it switches back to suggesting Rake again. This is really confusing, since it used to just keep showing Rake during times when you were Rake spamming, and now it fools you into thinking you should hit Mangle next, even when Rake is what you should really be doing.

Kihrawr
Honored
Posts: 52
Joined: Wed May 25, 2011 3:12 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Kihrawr » Sun Oct 20, 2013 4:38 pm

Reverting to the release version of Ovale instead of the beta fixed this problem, so it appears to be a bug in Ovale rather than a bug in the script itself.

ShmooDude
Exalted
Posts: 1057
Joined: Tue Feb 08, 2011 5:51 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by ShmooDude » Sun Oct 20, 2013 5:05 pm

Yeah, the beta version of ovale has some internal changes that require a script update. The updated version of the script will be released simultaneously with the release version of ovale.

Katjia
Posts: 16
Joined: Mon Sep 16, 2013 4:51 am

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Katjia » Wed Oct 23, 2013 8:28 pm

Still getting script lockups and its still telling me to clip strong bleeds with much weaker ......?
any fixes for this? Its driving me potty

ShmooDude
Exalted
Posts: 1057
Joined: Tue Feb 08, 2011 5:51 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by ShmooDude » Wed Oct 23, 2013 11:55 pm

Katjia wrote:Still getting script lockups and its still telling me to clip strong bleeds with much weaker ......?
any fixes for this? Its driving me potty
What ovale and script version?

Katjia
Posts: 16
Joined: Mon Sep 16, 2013 4:51 am

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Katjia » Thu Oct 24, 2013 5:58 am

Will check ovale later but the script is the new one you posted a couple pages back for me
last night I had 13second left on rip double trink one.. ror re procced and it wants me to renew it... with a weaker one

The lockups are random somtimes it now happen other times it xan happen a couple times per fight like pride hc last night... usually using tf I noticed fixes this 80% of the time until the next lockup

Jeshu
Revered
Posts: 244
Joined: Tue Dec 14, 2010 5:34 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Jeshu » Thu Oct 24, 2013 8:47 am

@ShmooDude: Can you test if the DoC workaround is still needed in the Leafkiller script on Ovale 5.4.3beta5 or higher?

ShmooDude
Exalted
Posts: 1057
Joined: Tue Feb 08, 2011 5:51 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by ShmooDude » Fri Oct 25, 2013 5:34 pm

Jeshu wrote:@ShmooDude: Can you test if the DoC workaround is still needed in the Leafkiller script on Ovale 5.4.3beta5 or higher?
Still necessary

Jeshu
Revered
Posts: 244
Joined: Tue Dec 14, 2010 5:34 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Jeshu » Sat Oct 26, 2013 6:30 pm

Reading through the script after merging into my master branch, I see this:

Code: Select all

AddFunction ArmorReduction asValue=1
{
    if target.DebuffPresent(WEAKENED_ARMOR any=1)
    {
        if target.Level(less 1) 0.679
        0.698
    }
    if target.Level(less 1) 0.651
    0.671
}
Is that meant to be RelativeLevel() instead? Or perhaps target's level minus player's level?

ShmooDude
Exalted
Posts: 1057
Joined: Tue Feb 08, 2011 5:51 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by ShmooDude » Sat Oct 26, 2013 9:28 pm

Basically it says if boss level mob use boss level armor, otherwise use level 92 armor.

EDIT: Because boss level mobs are considered level -1.

Gynaecology
Posts: 18
Joined: Mon Jul 22, 2013 2:26 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Gynaecology » Tue Oct 29, 2013 4:27 pm

Ovale doesn't seem to be correctly suggesting Force of Nature. Is this an issue on my end? It will tell me to cast once pre-pull, but it will just sit at 3 charges. I'm currently using weakauras to track and cast it myself, but I was wondering if this should be working through ovale.

Thanks.

Jeshu
Revered
Posts: 244
Joined: Tue Dec 14, 2010 5:34 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Jeshu » Wed Oct 30, 2013 4:38 pm

I'll probably be releasing one more beta for Ovale 5.4.3 this week and the final release will contain new default scripts for all of the classes and specs.

I also plan on releasing a beta of Nerien's Ovale Scripts this week containing the latest Leafkiller feral script maintained by @aggixx and @ShmooDude in this thread. It will require the latest beta version of Ovale due to extra language features that are used.

Spanja
Posts: 31
Joined: Sun Jan 13, 2013 12:11 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Spanja » Wed Oct 30, 2013 6:57 pm

With latest Ovale beta & latest beta public ShmooDude script, on every 4CP or more it asks me to FB and never ask to apply a rip.

ShmooDude
Exalted
Posts: 1057
Joined: Tue Feb 08, 2011 5:51 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by ShmooDude » Wed Oct 30, 2013 7:52 pm

Spanja wrote:With latest Ovale beta & latest beta public ShmooDude script, on every 4CP or more it asks me to FB and never ask to apply a rip.
beta 7 has a bug with timetodie, go back to beta 6 and it should behave better. He's already fixed the bug internally but hasn't released a new beta with the fix yet.

aavlee
Posts: 2
Joined: Thu Oct 31, 2013 12:09 am

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by aavlee » Thu Oct 31, 2013 12:30 am

Hey guys, I just started playing Feral DPS and Ovale/Leafkiller script is really helping. I've noticed that it is getting my to use rake a lot. Open with Savage Roar, Rake, and then usually another 2-3 rakes. It does get me to Mangle sometimes, but I haven't figured out how it decides which one to use. It feels like it is using Rake as the main combo builder. I'm too new to figure out what is right. Can anyone give any insight to this? I'm using 5.4.2.1 with Ovale 5.4.2

Thanks!!

ShmooDude
Exalted
Posts: 1057
Joined: Tue Feb 08, 2011 5:51 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by ShmooDude » Thu Oct 31, 2013 9:41 am

aavlee wrote:Hey guys, I just started playing Feral DPS and Ovale/Leafkiller script is really helping. I've noticed that it is getting my to use rake a lot. Open with Savage Roar, Rake, and then usually another 2-3 rakes. It does get me to Mangle sometimes, but I haven't figured out how it decides which one to use. It feels like it is using Rake as the main combo builder. I'm too new to figure out what is right. Can anyone give any insight to this? I'm using 5.4.2.1 with Ovale 5.4.2

Thanks!!
If rake will out damage mangle and not overwrite a significantly stronger rake bleed, it will use that as a filler instead of mangle. This happens at high agi/mastery (rune proc, some agi trinket procs) depending on your gear (if you have a bad weapon for your gear, it'll happen more frequently).

aavlee
Posts: 2
Joined: Thu Oct 31, 2013 12:09 am

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by aavlee » Thu Oct 31, 2013 1:23 pm

Thank you! That makes sense. I was looking at the bleed ratios and it never got me to clip with a weaker bleed. My weapon is pretty bad so that makes sense with the mangle.

Raolf
Posts: 10
Joined: Wed May 22, 2013 3:16 am

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Raolf » Fri Nov 01, 2013 12:56 am

Jeshu wrote:I'll probably be releasing one more beta for Ovale 5.4.3 this week and the final release will contain new default scripts for all of the classes and specs.

I also plan on releasing a beta of Nerien's Ovale Scripts this week containing the latest Leafkiller feral script maintained by @aggixx and @ShmooDude in this thread. It will require the latest beta version of Ovale due to extra language features that are used.
Does this mean we should be using this version combo, despite the numbers not matching? Nerien v5.4.5beta/Ovale v5.4.3beta8

Or did ShmooDude post another pastebin that I missed?

Also, I'm getting this error on every UI load:
Spoiler: show
Message: ...ddOns\Nerien_Ovale_Scripts\class\druid\ShmooDude.lua:3: attempt to index field 'script' (a nil value)
Time: 10/31/13 23:40:13
Count: 1
Stack: ...ddOns\Nerien_Ovale_Scripts\class\druid\ShmooDude.lua:3: in main chunk

Locals: _ = "Nerien_Ovale_Scripts"
NerienOvaleScripts = <table> {
SetDefaultModuleLibraries = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:398
Enable = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:325
NewModule = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:266
EnableModule = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:363
modules = <table> {
}
GetModule = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:241
IterateEmbeds = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:473
IsModule = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:499
defaultModuleLibraries = <table> {
}
SetEnabledState = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:455
enabledState = true
Ovale = <table> {
}
GetName = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:310
defaultModuleState = true
Disable = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:345
IterateModules = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:468
name = "NerienOvaleScripts"
SetDefaultModulePrototype = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:440
IsEnabled = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:482
orderedModules = <table> {
}
SetDefaultModuleState = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:418
DisableModule = <function> defined @Interface\AddOns\Ovale\Libs\AceAddon-3.0\AceAddon-3.0.lua:381
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'script' (a nil value)"
That's with all other addons turned off.

ShmooDude
Exalted
Posts: 1057
Joined: Tue Feb 08, 2011 5:51 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by ShmooDude » Fri Nov 01, 2013 1:05 am

@Raolf Match the number at the top of the leafkiller script to the ovale version, not the nerien's version. The leafkiller's in the nerien beta is 5.4.3.0 (I think that's what I set it as) so it matches ovale 5.4.3

As far as the error. I dunno, I have no problems with Nerien v5.4.5beta/Ovale v5.4.3beta8

Jeshu
Revered
Posts: 244
Joined: Tue Dec 14, 2010 5:34 pm

Re: Leafkiller's MoP Feral/Guardian Ovale Script

Post by Jeshu » Fri Nov 01, 2013 12:46 pm

That error is fixed in the final 5.4.5 release. It's a reference to a file that's already been removed from the addon, but if you are hand-updating to beta releases, then I think that file stays around. The release removes the reference to that file.

Locked